-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut scikit-image dependency #67
Conversation
Although slower, the time difference for a (400, 500) image is 0.02 vs 0.2 seconds
I was also thinking of removing |
|
Co-authored-by: Zhang Yunjun <yunjunz@outlook.com>
The specific reason was to try and make downstream packages that use PySolid (like If I take the
And building when docker image with those two environments fies, the one with matplotlib is about double in size the one without:
So in practice you're right that for a lot of people who are going to install pysolid into some big all-encompasing environment, it makes no difference. but if (and when) isce3 splits off from |
We definitely need to remove matplotlib for obvious reasons that @scottstanie mentioned above. It actually came up already on data system side. Up to you guys if you want to do that in this PR or a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me. Thank you @scottstanie!
Removing Regarding the dependency files, I believe |
Also hopefully this fixes this CI that was stuck
The CI looked normal to me. It usually takes ~1 hour to finish all the testing on various Linux versions (https://github.com/insarlab/PySolid/actions/runs/5570498743/job/15083276586?pr=63). |
Oh whoops! Sorry about cancelling then |
The
resize
function is a thin wrapper aroundndimage.zoom
. There were only a few names changed.The add an anti-aliasing filter, which might make more of a difference in other cases, but the SET is so smooth that it doesn't matter for us. The difference is approximately 0: