Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): react-native 0.72 #7210

Merged
merged 1 commit into from
Jul 17, 2023
Merged

build(deps): react-native 0.72 #7210

merged 1 commit into from
Jul 17, 2023

Conversation

mikehardy
Copy link
Collaborator

Description

note this will not work on android until an upstream issue is fixed that crashes on use of direct debugging, should be in 0.72.2

There are rumors that the New Architecture works with use_frameworks as of 0.72 so I'm keen to start playing with it, this is just one step on that path

Release Summary

Should not trigger a release - non-releasing conventional commits codes

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

It is the test app


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 8:16pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
react-native-firebase-next ⬜️ Ignored (Inspect) Jul 17, 2023 8:16pm

@mikehardy mikehardy changed the title build(deps): react-native 0.72 WIP build(deps): react-native 0.72 for tests app Jul 17, 2023
@mikehardy mikehardy changed the title build(deps): react-native 0.72 for tests app build(deps): react-native 0.72 Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #7210 (65c3f2e) into main (2b9dc73) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7210      +/-   ##
============================================
+ Coverage     53.80%   53.87%   +0.08%     
- Complexity      735      741       +6     
============================================
  Files           231      231              
  Lines         11628    11629       +1     
  Branches       1864     1864              
============================================
+ Hits           6255     6264       +9     
+ Misses         5026     5022       -4     
+ Partials        347      343       -4     

@mikehardy mikehardy merged commit ede9bb6 into main Jul 17, 2023
16 of 17 checks passed
@mikehardy mikehardy deleted the dependency-updates-rn72 branch July 17, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant