Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): remove exception throw on inequality queries on different fields #7885

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

russellwheatley
Copy link
Member

Description

Related issues

fixes: #7845

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 2:48pm

@Salakar Salakar added the blocked: do-not-merge Do not merge this issue without approval by the person who labelled this issue as Do Not Merge label Jul 8, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (9b8dda7) to head (130b2f8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7885      +/-   ##
==========================================
- Coverage   68.13%   68.12%   -0.01%     
==========================================
  Files         156      156              
  Lines        6278     6275       -3     
  Branches     1267     1263       -4     
==========================================
- Hits         4277     4274       -3     
  Misses       1896     1896              
  Partials      105      105              

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@mikehardy mikehardy merged commit da24246 into main Jul 15, 2024
19 checks passed
@mikehardy mikehardy deleted the firestore-7845 branch July 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] 🔥Support for inequality filters on multiple fields
4 participants