Don't store untyped AST in state #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
reviewed
Dec 28, 2020
| @@ -105,7 +105,7 @@ type FsacClient(sendServerRequest: ClientNotificationSender) = | |||
| type BackgroundServiceServer(state: State, client: FsacClient) = | |||
| inherit LspServer() | |||
|
|
|||
| let checker = FSharpChecker.Create(projectCacheSize = 1, keepAllBackgroundResolutions = false, suggestNamesForErrors = true) | |||
| let checker = FSharpChecker.Create(projectCacheSize = 1, keepAllBackgroundResolutions = false, suggestNamesForErrors = false) | |||
There was a problem hiding this comment.
We make projectCacheSize 200 by default, it should probably just be 1000 or something silly. I highly recommend increasing its size. It significantly increases the CPU and memory usage of FCS for multi-project solutions because of a high degree of cache thrashing. Whatever guidance existed about this number before we did an actual investigation of this is wrong. See here for more info: dotnet/fsharp#10217
There was a problem hiding this comment.
Oh, this is in the background service. Hmm. Not sure what to think of that, I assum eit only touches one project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly reduces memory usage, especially on big projects. On
FSharp.slnI observed reducing memory usage in main FSAC process from 2800 MB to 2100 MB in similar usage scenario (initial load, wait for background service to stabilize, do some small operations in a file fromFSharp.Compiler.Service.fsproj)Memory dump pre-change: (notice super high allocations for objects from AST)
Memory dump post-change:
