This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix(prq): fix a bunch of goroutine leaks and deadlocks #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we'll wait forever.
ghost
assigned 
Stebalien
commented
Feb 27, 2019
| @@ -228,7 +237,7 @@ func (pqm *ProviderQueryManager) findProviderWorker() { | |||
| wg.Add(1) | |||
| go func(p peer.ID) { | |||
| defer wg.Done() | |||
| err := pqm.network.ConnectTo(pqm.ctx, p) | |||
| err := pqm.network.ConnectTo(findProviderCtx, p) | |||
There was a problem hiding this comment.
Is this correct? I can't remember if we did this for a reason.
There was a problem hiding this comment.
Historical note: this was not correct. See #226.
|
(reviewed by @hannahhoward) |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
fix(prq): fix a bunch of goroutine leaks and deadlocks This commit was moved from ipfs/go-bitswap@52d6095
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a few tests but we should probably prioritize bitswap test coverage in the near future.