add a utility method for sorting CID slices #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
added
the
status/blocked
Stebalien
force-pushed
the
fix/cid-slice
branch
from
e14088c
to
0563979
Compare
|
@Stebalien merge when ready. |
lanzafame
reviewed
Sep 24, 2018
| } | ||
|
|
||
| // Sort sorts a slice of CIDs | ||
| func Sort(s []cid.Cid) { |
There was a problem hiding this comment.
Why not wrap either sort.Slice or sort.SliceStable and then the Slice type isn't required?
There was a problem hiding this comment.
sort.Slice uses reflection so it's not quite as fast. It may not make a difference but it's not exactly a ton of code.
There was a problem hiding this comment.
True, this may just be me having an aversion to named slice types more than anything else :)
There was a problem hiding this comment.
Well... when go introduces proper generics all this stuff will magically disappear. Until then, we have hand-coded monomorphization.
😞
Stebalien
force-pushed
the
fix/cid-slice
branch
from
0563979
to
e23b860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked on the CID string refactor
fixes ipfs/go-cid#46