fix: prevent interop timeouts with fast fixture loading #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deps: update ipfsd-ctl and kubo-rpc-client * chore: apply suggestions from code review * tmp: get some debug logs from CI jobs * fix: disable delegated routing in vfetch-interop tests * fix: test:node on windows * Revert "tmp: get some debug logs from CI jobs" This reverts commit 3654a28.
SgtPooki
commented
May 8, 2024
Comment on lines
+16
to
+17
| gateways: ['http://127.0.0.1:8180'], | ||
| routers: [] |
There was a problem hiding this comment.
see ipfs/js-ipfsd-ctl#831 for why we can't just use the same info from ipfsd-ctl
Comment on lines
+11
to
+22
| /** | ||
| * fast-glob does not like windows paths, see https://github.com/mrmlnc/fast-glob/issues/237 | ||
| * fast-glob performs search from process.cwd() by default, which will be: | ||
| * 1. the root of the monorepo when running tests in CI | ||
| * 2. the package root when running tests in the package directory | ||
| */ | ||
| let globRoot = process.cwd().replace(/\\/g, '/') | ||
| if (!globRoot.includes('packages/interop')) { | ||
| // we only want car files from the interop package | ||
| globRoot = [...globRoot.split('/'), 'packages/interop'].join('/') | ||
| } | ||
| for (const carFile of await fg.glob('src/fixtures/data/*.car', { cwd: globRoot })) { |
There was a problem hiding this comment.
this could likely be smarter, and will likely break if we're running this elsewhere (via the binary for the package)
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
## @helia/verified-fetch-interop [1.21.1](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-interop-1.21.0...@helia/verified-fetch-interop-1.21.1) (2024-05-08) ### Bug Fixes * prevent interop timeouts with fast fixture loading ([#73](#73)) ([a43d994](a43d994))
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: prevent interop timeouts with fast fixture loading
Description
Attempting to merge pr #72 into main instead of onto #70
Related: #72
Related: #70
Notes & open questions
no idea why github CI continues to fail on #70
Change checklist