Add global lru for routes with keys being the appname + path #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucirello
suggested changes
Jan 3, 2017
| @@ -5,4 +5,8 @@ Copyright 2013 Julien Schmidt. All rights reserved. BSD-license | |||
|
|
|||
| For: api/server/internal/routecache/lru.go | |||
| For: api/server/singleflight.go | |||
| Copyright 2012 Google Inc. All rights reserved. Apache 2 license | |||
| return | ||
| } | ||
|
|
||
| // Delete ... |
There was a problem hiding this comment.
function description is missing.
| @@ -99,5 +99,8 @@ func (s *Server) handleRouteCreate(c *gin.Context) { | |||
| return | |||
| } | |||
|
|
|||
| // For any create just push the new route to the front of the list | |||
There was a problem hiding this comment.
Is this comment really necessary? it seems quite self-evident for me that Refresh will push the new route to the front of the list.
ucirello
reviewed
Jan 5, 2017
| For: api/server/singleflight.go |
ucirello
approved these changes
Jan 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a global LRU for routes matching during function calls