Add tokenStart and tokenEnd to query

[North101]

I wanted to be able to offer auto complete suggestions for my search query and for that I needed to know the location of the Query to figure out if it was at my cursor position.

This PR adds the start / end position of the Query relative to input.

[North101]

I also would like to make the <exp> part of field:<exp> and field=<exp> optional. Though this is would be a breaking change. If you don't want that I'm happy to just keep it in my fork

[isoos]

I think this is a good feature to add, but please:

• add tests, the more the better to see (a) what is now available and (b) how to use/access it (it can be a new file)
• explain a bit how the optional exp is breaking, and maybe also add tests there too with comments
• also update the changelog and bump the version

[North101]

• add tests, the more the better to see (a) what is now available and (b) how to use/access it (it can be a new file)

Sure. I didn't want to write them until you gave it an ok :P

• explain a bit how the optional exp is breaking, and maybe also add tests there too with comments

It was failing one test but I was able to make a minor change or to get it to pass. Another reason it might be breaking is because the following used to error but now parses because it used to expect something after the ::

field: AND somethingelse

• also update the changelog and bump the version

Cool. Will do after the tests

[North101]

I've changed FieldScopeQuery and FieldCompareQuery to take TextQuery instead of String as I found I needed to know the start/end index of the field. I added a getter to keep them backwards compatible.

[isoos]

I've changed FieldScopeQuery and FieldCompareQuery to take TextQuery instead of String as I found I needed to know the start/end index of the field. I added a getter to keep them backwards compatible.

I will look the code later, but if this is a change that could possibly break more than one API, maybe it is worth doing it by bumping the major version and documenting what has been changed in a breaking way. Not yet sure if it is the case here, I'm just stating that it is not off the table.

[North101]

If you're happy with a major version bump then that'd make things easier.

[isoos]

If you're happy with a major version bump then that'd make things easier.

I don't mind, just make sure to add plenty of notes in the changelog to help users migrate.

[isoos]

On a high level I like this, but I'd like to do a deep dive into it before going forward with it. Unfortunately I have a few busy days before me, and it may happen only sometime next week :(

[North101]

On a high level I like this, but I'd like to do a deep dive into it before going forward with it. Unfortunately I have a few busy days before me, and it may happen only sometime next week :(

No prob. I'm using this branch in my project for now so no rush

[isoos]

Thank you for all the changes you've done! Only one big question remains about the type of the operator.

For the other two, I'm happy to do them, but I'm unsure which name to use for the span field/class. Any preference?

[isoos]

Is the change from String to TextQuery for the operator field correct?

[North101]

It could help figure out where the operator is.

e.g. all of these are valid:

field=value
field = value
field    =    value

[isoos]

I think this should be a separate FieldOperator extends Query type, with text or value + position. The TextQuery has isExactMatch which doesn't make sense for this field, and it doesn't feel right. wdyt?

[North101]

Does it make sense to have FieldCompareQuery.field, FieldCompareQuery .operator and FieldScope.operator all share the same class. e.g. something like

class FieldElementQuery extends Query {
  final String text;
  const FieldElementQuery({
    required this.text,
    required super.position,
  });

  @override
  String toString({bool debug = false}) =>
      _debug(debug, text);
}

[North101]

Or... Remove isExactMatch from TextQuery as its only ever used for PhraseQuery?

I think this is what I prefer but I'm happy to for whatever you suggest

[isoos]

That is a good solution too!

[isoos]

This looks good! One small nit for the documentation part.

[isoos]

I'm really happy with the current state of the PR, thank you for idea and all the small follow-ups!
Do you have anything else in the works, or shall I release it?

[North101]

That's it for me. Thanks for the library! I've been able to make an advanced SQL db search with it and with this PR it now gives contextual suggests!

[isoos]

Great features! :)

Published as 2.0.0