Add support to see namespace when performing --dry-run #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
approved these changes
Jun 9, 2024
itzg
requested changes
Jun 9, 2024
itzg
previously approved these changes
Jun 9, 2024
|
Oh yeah, rcon web admin is broken for some reason. You might need to revert your changes for that chart unless you feel like investigating 😄 |
|
I can look into it, I just sent you an email for more details around the issue.
…________________________________
From: Geoff Bourne ***@***.***>
Sent: Sunday, June 9, 2024 7:28 PM
To: itzg/minecraft-server-charts ***@***.***>
Cc: Ryan Chauvin ***@***.***>; Author ***@***.***>
Subject: Re: [itzg/minecraft-server-charts] Add support to see namespace when performing --dry-run (PR #212)
Oh yeah, rcon web admin is broken for some reason. You might need to revert your changes for that chart unless you feel like investigating 😄
—
Reply to this email directly, view it on GitHub<#212 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEWISGGM7UBYVI64BDQKSD3ZGTXJBAVCNFSM6AAAAABJA7LKVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWHEZDKMBYGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
It's still reporting merge conflicts
|
itzg
approved these changes
Aug 30, 2024
|
It looks like the helm chart is struggling and I don't see this field in I'm already |
|
@toddejohnson please try out this chart release https://github.com/itzg/minecraft-server-charts/releases/tag/minecraft-4.22.2 |
|
Applied without issues. Thank you for the quick fix @ryanchauvin!!! Whew I was sweating for a bit as I don't know how to get Flux to reference a git tag helm chart. I saw it published to the normal URL and it has applied without issues. |
|
Sorry for the oversight, glad it’s working now 😊
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Todd Johnson ***@***.***>
Sent: Friday, August 30, 2024 4:36:57 PM
To: itzg/minecraft-server-charts ***@***.***>
Cc: Ryan Chauvin ***@***.***>; Mention ***@***.***>
Subject: Re: [itzg/minecraft-server-charts] Add support to see namespace when performing --dry-run (PR #212)
Applied without issues. Thank you for the quick fix @ryanchauvin<https://github.com/ryanchauvin>!!!
Whew I was sweating for a bit as I don't know how to get Flux to reference a git tag helm chart. I saw it published to the normal URL and it has applied without issues.
—
Reply to this email directly, view it on GitHub<#212 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEWISGFU2YPBBSBNQWM6JG3ZUDQXTAVCNFSM6AAAAABJA7LKVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSGM3TAOJRGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to see namespace in yaml files when performing --dry-run for all charts.