Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting loadBalancerClass #228

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

josephshanak
Copy link
Contributor

For services spec.loadBalancerClass allows you to specify a LoadBalancer implementation other than the cloud provider default:

https://kubernetes.io/docs/concepts/services-networking/service/#load-balancer-class

This PR adds the ability to specify the loadBalancerClass for the Minecraft and RCON services.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please merge from master and bump the chart version one more time? Another PR got merged ahead of yours.

@josephshanak
Copy link
Contributor Author

Thanks! Can you please merge from master and bump the chart version one more time? Another PR got merged ahead of yours.

Done.

@itzg itzg merged commit ed3317b into itzg:master Aug 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants