Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement is_new() in Paris #40

Closed
treffynnon opened this issue Nov 29, 2012 · 2 comments
Closed

Implement is_new() in Paris #40

treffynnon opened this issue Nov 29, 2012 · 2 comments
Assignees
Milestone

Comments

@treffynnon
Copy link
Collaborator

In idiorm there is an is_new() method but it is not implemented in Paris yet.

@ghost ghost assigned treffynnon Nov 29, 2012
This was referenced Nov 29, 2012
treffynnon added a commit that referenced this issue Nov 29, 2012
@tag
Copy link
Contributor

tag commented Nov 29, 2012

I like that it's been added to ORM, but we need to be very careful when adding methods to Model, as it's reasonable to expect some model may have a similarly named method.

As $someModel->orm is public, this is still accessible to the end user through the orm property.

@treffynnon
Copy link
Collaborator Author

You're right it is a dangerous line to walk down and I am sure there will be bug report at some point mentioning a method clash! Still most implementers will hopefully be following the changelog of the project. It is a real toss-up between convenience and protecting against BC breaks - it is tough to decide for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants