version 94 (#51)

MN and NI added. Closes #50
jacoelho · Apr 16, 2023 · e8b1f1b · e8b1f1b
1 parent 8517a59
commit e8b1f1b
Show file tree

Hide file tree

Showing 15 changed files with 207 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -10,8 +10,10 @@ default: build
 build: test
 	go install -v ./...
 
-.PHONY: generate
-generate:
+$(GOBIN)/banking-registry:
+	cd registry; go install ./cmd/banking-registry
+
+generate: $(GOBIN)/banking-registry
 	go generate -v ./...
 
 .PHONY: test

diff --git a/docs/registry.yml b/docs/registry.yml
@@ -460,6 +460,14 @@ countries:
     account_number: 3:13
     sepa: false
 
+  - code: MN
+    name: Mongolia
+    IBAN: MN2!n4!n12!n
+    BBAN: 4!n12!n
+    bank_code: 0:4
+    account_number: 4:16
+    sepa: false
+
   - code: MR
     name: Mauritania
     IBAN: MR2!n5!n5!n11!n2!n
@@ -488,6 +496,14 @@ countries:
     account_number: 8:26
     sepa: false
 
+  - code: NI
+    name: Nicaragua
+    IBAN: NI2!n4!a20!n
+    BBAN: 4!a20!n
+    bank_code: 0:4
+    account_number: 4:24
+    sepa: false
+
   - code: NL
     name: The Netherlands
     IBAN: NL2!n4!a10!n

diff --git a/iban/bban_helper.go b/iban/bban_helper.go
diff --git a/iban/bban_test.go b/iban/bban_test.go
@@ -853,6 +853,28 @@ func TestBBAN(t *testing.T) {
 				AccountNumber:    "001000100141",
 			},
 		},
+		{
+			iban:    "MN121234123456789123",
+			wantErr: false,
+			bban: iban.BBAN{
+				BBAN:             "1234123456789123",
+				BankCode:         "1234",
+				BranchCode:       "",
+				NationalChecksum: "",
+				AccountNumber:    "123456789123",
+			},
+		},
+		{
+			iban:    "NI45BAPR00000013000003558124",
+			wantErr: false,
+			bban: iban.BBAN{
+				BBAN:             "BAPR00000013000003558124",
+				BankCode:         "BAPR",
+				BranchCode:       "",
+				NationalChecksum: "",
+				AccountNumber:    "00000013000003558124",
+			},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.iban,

diff --git a/iban/checksum_test.go b/iban/checksum_test.go
@@ -78,6 +78,7 @@ func TestChecksum(t *testing.T) {
 		{iban: "IQ98NBIQ850123456789012", want: "98"},
 		{iban: "BR9700360305000010009795493P1", want: "97"},
 		{iban: "DK0206715394960066", want: "02"},
+		{iban: "NI45BAPR00000013000003558124", want: "45"},
 	}
 	for _, tt := range tests {
 		tt := tt

diff --git a/iban/country_constants.go b/iban/country_constants.go
diff --git a/iban/country_mongolia.go b/iban/country_mongolia.go
diff --git a/iban/country_nicaragua.go b/iban/country_nicaragua.go
diff --git a/iban/generate.go b/iban/generate.go
diff --git a/iban/iban.go b/iban/iban.go
@@ -2,6 +2,8 @@ package iban
 
 import "github.com/jacoelho/banking/pool"
 
+//go:generate banking-registry -registry-file ../docs/registry.yml -dst-directory .
+
 // PaperFormat returns iban in paper format
 // Follows EBS  204 - 5 IBAN Format  2) Paper Format
 func PaperFormat(iban string) string {

diff --git a/iban/sepa.go b/iban/sepa.go
diff --git a/iban/sepa_test.go b/iban/sepa_test.go
@@ -1,5 +1,3 @@
-//go:build validation
-
 package iban
 
 import (
@@ -242,6 +240,16 @@ func TestIsSEPACountry(t *testing.T) {
 			want:        false,
 			wantErr:     false,
 		},
+		{
+			countryCode: "MN",
+			want:        false,
+			wantErr:     false,
+		},
+		{
+			countryCode: "NI",
+			want:        false,
+			wantErr:     false,
+		},
 	}
 	for _, tt := range tests {
 		tt := tt

diff --git a/iban/validate.go b/iban/validate.go
diff --git a/iban/validate_test.go b/iban/validate_test.go
@@ -335,6 +335,14 @@ func TestValidateIBAN(t *testing.T) {
 			iban:    "SO211000001001000100141",
 			wantErr: false,
 		},
+		{
+			iban:    "MN121234123456789123",
+			wantErr: false,
+		},
+		{
+			iban:    "NI45BAPR00000013000003558124",
+			wantErr: false,
+		},
 	}
 	for _, tt := range tests {
 		tt := tt

diff --git a/registry/cmd/generator/main.go → registry/cmd/banking-registry/main.go b/registry/cmd/generator/main.go → registry/cmd/banking-registry/main.go