Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cq.Data fails, but Cq.Attr works #104

Closed
drgrieve opened this issue Jun 4, 2013 · 7 comments
Closed

Cq.Data fails, but Cq.Attr works #104

drgrieve opened this issue Jun 4, 2013 · 7 comments
Labels
Milestone

Comments

@drgrieve
Copy link

drgrieve commented Jun 4, 2013

reference.Cq().Data("citationprefix") => The value 'see' could not be parsed, it doesn't seem to be something that should be a JSON value"

reference.Cq().Attr("data-citationprefix") => "see"

@jamietre
Copy link
Owner

jamietre commented Jun 4, 2013

I just pushed a prerelease 1.3.5-beta5 on nuget incorporating this fix.

@drgrieve
Copy link
Author

drgrieve commented Jun 6, 2013

Thanks, confirming that the fix is working.

Also thanks for the library - A real time saver now I have my head around the basic usage.

@drgrieve
Copy link
Author

drgrieve commented Jun 6, 2013

string not working as strong type, but bool is

(string)url.Cq().Data("linktext") => "Dave"

url.Cq().Data("linktext") => "The value 'Dave' could not be parsed to type 'System.String"

url.Cq().Data("uselinkastext") => false

@jamietre
Copy link
Owner

jamietre commented Jun 6, 2013

Not quite sure I understand the last comment - can you show me the markup used for that example?

@drgrieve
Copy link
Author

drgrieve commented Jun 7, 2013

Sorry screwed up the copy and paste (angel brackets being removed)

url.Cq().Data<string>("linktext")  
  //=> "The value 'Dave' could not be parsed to type 'System.String" fails

(string)url.Cq().Data("linktext") 
  //=> "Dave" works

url.Cq().Data<bool>("uselinkastext") 
  //=> false works

jamietre added a commit that referenced this issue Jun 7, 2013
@jamietre
Copy link
Owner

jamietre commented Jun 7, 2013

Fixed on github. If you need this fix now pull down the DLL from here (not going to update nuget just yet).

@304NotModified
Copy link

Is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants