Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common.cpp: add --enable-special-out and --disable-special-out for ov… #3

Closed

Conversation

mofosyne
Copy link

…erride default special token handling behavior

Possible approach to address @HanClinto idea for a flag ggerganov#6923

Investigated using --conversation flag, but it touching multiple other logic so has much different semantic than this idea.

Also @jart would prefer keeping the different default special token behavior.

It would be nice if the 'settings' store has default behaviour + override flag... e.g. DEFAULT, OVERRIDE_TRUE, OVERRIDE_FALSE or something. But anyway this is the best approximation

…erride default special token handling behavior
@jart
Copy link
Owner

jart commented May 18, 2024

The --conversation flag is so new I honestly don't know what it does.

I don't think it makes sense here to have two flags. I did that before, with --fast and --precise, but I think that's really an exception to the rule. Ideally the project should make a decision about what the default behavior should be, and then have a single flag to make that not happen.

@jart jart force-pushed the grammar-token branch 2 times, most recently from a285e3c to d8b373c Compare May 21, 2024 15:12
@mofosyne mofosyne closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants