Misc updates to find_device(), wizard, and repr(device) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome @uzlonewolf ! I love the wizard enhancement/fix and expanding repr! On the find_device() API updates, I agree on your approach. I'll increment to 1.8.0 to keep with our versioning convention and note the minor breaking change form 1.7.1 in the release notes. Thank you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way find_device() returned a tuple didn't sit right with me, so I made it return a dict instead. This will also allow expanding the info returned in the future without breaking anything. I screwed up and forgot to submit a PR for this before 1.7.1 dropped, but hopefully it's recent enough that this breaking change won't be too bad.
Wizard now detects more cloud errors, namely wrong Regions and Device IDs. Fixes #195
I also updated repr to include a bit more information and what type of device it is. Still not perfect and is missing some info (such as nodelay), but it's a lot better.