Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to fix trivial link error #434

Merged
merged 1 commit into from
Oct 2, 2022
Merged

try to fix trivial link error #434

merged 1 commit into from
Oct 2, 2022

Conversation

fanofxiaofeng
Copy link
Contributor

@fanofxiaofeng fanofxiaofeng commented Oct 2, 2022 •
edited
Loading

image

When I clicked on the link, a _404_ page appeared

image

So I think the link might be wrong

image

And I tried to fix this trivial link error

@fanofxiaofeng
try to fix trivial link error
eea8c2b 
try to fix trivial link error
@fanofxiaofeng
Copy link
Contributor Author

If this pull request gets merged, then the README.md file will be linking to itself which is not consistent with the description inside the red box 😂
image

@chibash chibash merged commit 73c5be4 into jboss-javassist:master Oct 2, 2022
@chibash
Copy link
Member

chibash commented Oct 2, 2022

Thanks. I also fixed the inconsistency above.

@fanofxiaofeng fanofxiaofeng deleted the patch-1 branch October 3, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanofxiaofeng @chibash