Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit_uri starting with http when using ssh #120

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Conversation

auduny
Copy link
Contributor

@auduny auduny commented Sep 11, 2023

Quick hack working edit_uri for git+ssh repos

Fixes #119

Quick hack working `edit_uri` for git+ssh repos
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Version Number Check

Update the version in pyproject.toml if you want this PR to generate a new release (main is 0.7.0 >= 0.7.0).

@jdoiro3
Copy link
Owner

jdoiro3 commented Sep 28, 2023

Apologies for letting this PR hang around. I'd like to add some testing around this feature before merging but have been kicking the can down the road.

@vschettino-asimov
Copy link

Just noticed the same behavior and that fix would help us as well :)

Copy link

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@jdoiro3 jdoiro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my one comment LGTM.

mkdocs_multirepo_plugin/structure.py Outdated Show resolved Hide resolved
@jdoiro3 jdoiro3 merged commit 2f6543d into jdoiro3:main Jun 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ssh-uri repos in combination with edit urls
4 participants