Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fish completion support #772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sikmir
Copy link
Contributor

@sikmir sikmir commented Aug 3, 2024

Make sure that you've checked the boxes below before you submit PR:

Always

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Written well with PR title, we generate the release notes base on that

For the bug fixes or features only

  • Quality Gate Passed. Change this URL to your PR.
  • The coverage is xxx on the new lines
  • I've tested it by manual in the following platform
    • MacOS
    • Linux
    • Windows
  • Unit Test covered
  • e2e Test covered

@LinuxSuRen
Copy link
Member

There are some errors that need to be fixed. I will do it due to it is not caused by this PR. And thanks for your time.

@LinuxSuRen
Copy link
Member

LinuxSuRen commented Aug 5, 2024

I removed some outdated config and tests. #773

hi @sikmir , please update your branch from the master branch. Thanks.

@LinuxSuRen LinuxSuRen closed this Aug 5, 2024
@LinuxSuRen LinuxSuRen reopened this Aug 5, 2024
@sikmir
Copy link
Contributor Author

sikmir commented Aug 5, 2024

I removed some outdated config and tests. #773

hi @sikmir , please update your branch from the master branch. Thanks.

Updated, but still failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants