[JENKINS-63421] Add agentServiceAccounts optional config #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to address: JENKINS-63421.
This plugin assigns Jenkins permissions based on their GitHub permissions - if a user can read a repo then they can view and execute the job.
However there exists no role that to represent the service account used by Jenkins agents to connect to the controller. This means that plugin users are forced to make the service account an admin, and this presents a security risk because the service account credentials exist on every agent if you know where to look.
An attacker can take the credentials from the agent and use them to become a Jenkins admin.
Our fork introduces a configurable
agentServiceAccounts
field which has the proper, reduced permissions.Testing done
Unit tests have been included in the commit.
This has been deployed to production on our instance and it's been working well. We use the CasC plugin and so can verify that works too.
Submitter checklist