Expand local manifest #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there was a reason this was left out I wouldn't know :) Maybe there is a risk that the xml format might contain variable names that shouldn't be expanded? But it seems unlikely to me. |
|
Great, thanks for merging @rsandell ! Do you think it's worth releasing a 1.10.3 for this change? Would be great for my team at least ;) |
|
I had a bunch of other plugins to release yesterday, so I didn't get to this one before the day was over. But it is released now. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable expansion works for all other fields, but not for the local manifest. This makes it impossible to define the local manifest or its URL using environment variables or a pre SCM step.
My only concern about this change is that there might be a good reason why it was not implemented for the local manifest so far. If so I could improve the pull request and add a checkbox like "Do not expand variables in local manifest".
Also see https://issues.jenkins-ci.org/browse/JENKINS-37416 .