Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: make it mandatory to pass globalConfig to the Runtime constructor #15044

Merged
merged 2 commits into from
Apr 30, 2024
Merged

refactor!: make it mandatory to pass globalConfig to the Runtime constructor #15044

merged 2 commits into from
Apr 30, 2024

Conversation

mrazauskas
Copy link
Contributor

Summary

This PR makes it mandatory to pass globalConfig to the Runtime constructor.

Test plan

Green CI.

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3276f02
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/66307fb6e1fd6800088b0725
😎 Deploy Preview https://deploy-preview-15044--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me!

Comment on lines 2373 to +2374
// TODO: remove this check in Jest 30
if (this._globalConfig?.seed === undefined) {
if (this._globalConfig.seed === undefined) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I wanted to remove these checks since they are not needed in Jest 30. But here it also makes sure that this._globalConfig is defined.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@SimenB SimenB merged commit 654dbd6 into jestjs:main Apr 30, 2024
84 checks passed
@mrazauskas mrazauskas deleted the mandatory-globalConfig branch April 30, 2024 11:26
@SimenB
Copy link
Member

SimenB commented May 12, 2024

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants