Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary warnings on post cleanup #202

Closed
wants to merge 10 commits into from

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Sep 3, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Summary:

During post-cleanup, we attempt to publish build info and generate a job summary. While these are valuable features, errors in these tasks shouldn't unnecessarily alarm users.

Details:

This PR adds a check for a valid CLI version and moves related logs to the debug level, ensuring that users aren't alerted by errors they can't address themselves.

@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Sep 3, 2024
@EyalDelarea EyalDelarea changed the title Check CLI version before Auto Publish & Job Summary Check CLI version before Auto Build Publish & Job Summary Sep 4, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 4, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 4, 2024
@EyalDelarea EyalDelarea changed the title Check CLI version before Auto Build Publish & Job Summary Remove unnecessary warnings on post cleanup Sep 4, 2024
@EyalDelarea EyalDelarea closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant