Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vector inputs of solar parameters to Orbit initialization: ro, zo, vo, and solarmotion #595

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Jul 21, 2023

In all cases except for lists of Orbit instances for now.

@jobovy jobovy added this to the v1.10 milestone Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1707eb9) 99.91% compared to head (3b55dc6) 99.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         198      198           
  Lines       29161    29173   +12     
=======================================
+ Hits        29137    29149   +12     
  Misses         24       24           
Impacted Files Coverage Δ
galpy/orbit/Orbits.py 100.00% <100.00%> (ø)
galpy/util/conversion.py 100.00% <100.00%> (ø)
galpy/util/coords.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jobovy jobovy merged commit e3c691a into main Jul 21, 2023
60 checks passed
@jobovy jobovy deleted the vector-ro-input branch July 21, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant