Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 support #603

Merged
merged 37 commits into from
Feb 2, 2024
Merged

Add Python 3.12 support #603

merged 37 commits into from
Feb 2, 2024

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Sep 10, 2023

This issue just tracks progress to fully changing the build/test infrastructure to Python 3.12 Python 3.12 wheels are already being created successfully and are included in the latest release.

This PR tracks progress towards fully supporting Python 3.12. Any necessary fixes will be done separately outside of this PR, so actual Python 3.12 support can be achieved for many platforms before achieving it for all. We believe, in fact, that galpy fully works, but it is hard to fully test until all dependencies support Python 3.12.

Current status:

  • Linux works, but can't run tests dependent on JAX or numba, because they do not support Python 3.12 yet. This affects only the spherical DFs (for JAX) and the non-inertial-frame force tests
    • Test JAX-dependent code
    • Test numba-dependent code
  • Mac does not work because of an issue with installing h5py:
    • run Mac tests
  • Windows untested, because Windows tests use conda in the CI and conda does not support Python 3.12 yet.
    • Run Windows tests
  • Wheels:
    • Build Python 3.12 wheels for all platforms

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5a3bc9) 99.91% compared to head (2b93abc) 99.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         200      200           
  Lines       29363    29363           
=======================================
  Hits        29339    29339           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR has been automatically marked as stale because it has not had recent activity. Please close the PR if it is no longer relevant. If no further activity occurs, the PR may be closed. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Dec 11, 2023
@jobovy jobovy added pinned and removed Stale labels Dec 11, 2023
@jobovy jobovy merged commit 9f8f970 into main Feb 2, 2024
112 checks passed
@jobovy jobovy deleted the py312 branch February 2, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant