fix: removed excess logic for when a or b are empty strings

joebobmiles · Nov 10, 2022 · 31d93d0 · 31d93d0
1 parent baa3c01
commit 31d93d0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/diff.spec.ts b/src/diff.spec.ts
@@ -275,7 +275,7 @@ describe("diff", () =>
   });
 });
 
-describe.only("diffText", () =>
+describe("diffText", () =>
 {
   it.each([
     [ "", "" ],
@@ -292,13 +292,15 @@ describe.only("diffText", () =>
     [ "a", "ab", [ [ "add", 1, "b" ] ] ],
     [ "ab", "a", [ [ "delete", 1, undefined ] ] ],
     [ "ab", "ac", [ [ "delete", 1, undefined ], [ "add", 1, "c" ] ] ],
-    [ "ac", "bc", [ [ "delete", 0, undefined ], [ "add", 0, "b" ] ] ]
+    [ "ac", "bc", [ [ "delete", 0, undefined ], [ "add", 0, "b" ] ] ],
+    [ "ab", "", [ [ "delete", 0, undefined ], [ "delete", 0, undefined ] ] ],
+    [ "", "ab", [ [ "add", 0, "a" ], [ "add", 1, "b" ] ] ]
   ])("Returns a change tuple for sequences that are different", (a, b, diff) =>
   {
     expect(diffText(a, b)).toStrictEqual(diff);
   });
 
-  it.only.each([
+  it.each([
     [
       "hello",
       "goodbye",

diff --git a/src/diff.ts b/src/diff.ts
@@ -133,15 +133,13 @@ export const diffText = (a: string, b: string): any =>
     return undefined;
   else if (a.length === 0)
   {
-    return [
-      [ "add", 0, b ]
-    ];
+    return b.split("").map((character, index) =>
+      [ "add", index, character ]);
   }
   else if (b.length === 0)
   {
-    return [
-      [ "delete", 0, undefined ]
-    ];
+    return a.split("").map(() =>
+      [ "delete", 0, undefined ]);
   }
   else
   {