Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color in windows log console with colorama #1397

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

hansepac
Copy link
Contributor

@hansepac hansepac commented Feb 16, 2024

Fixes #943

Fix color in windows log console with colorama. Screenshots below are on Windows.

Before:
image

After:
image

Copy link

welcome bot commented Feb 16, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jasongrout jasongrout added the bug label Feb 16, 2024
Copy link
Contributor

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jupytext CI test is failing, but it seems to fail on a lot of recent PRs. I ran this branch locally on macos and everything seemed to be fine.

LGTM!

@blink1073 blink1073 merged commit 95d3b96 into jupyter-server:main Feb 16, 2024
34 of 38 checks passed
Copy link

welcome bot commented Feb 16, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please fix logging color on windows console
3 participants