Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Authentication to remote repo #1000

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Conversation

robna
Copy link
Contributor

@robna robna commented Aug 3, 2021

As an result of #993 I wrote a section for the Readme, to help new users setting up their SSH connection correctly in order to use the jupyterlab-git extension in connection with remotely hosted repositories.

@welcome
Copy link

welcome bot commented Aug 3, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

Binder 👈 Launch a binder notebook on branch robna/jupyterlab-git/master

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @robna

I left some suggestions to make it less opinionated towards GitHub.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Yes, very good improvements, especially to make it less focused on github

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Copy link
Contributor Author

@robna robna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added all changes from your review and marked as resolved. So it can be merged I guess.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robna

I reorganize a bit the README

@fcollonval fcollonval merged commit feb26f3 into jupyterlab:master Aug 4, 2021
@welcome
Copy link

welcome bot commented Aug 4, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants