Hide overflow for latest item on click #1212
Conversation
Otherwise a vertical scrollbar will appear when child button is clicked.
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
|
There was a problem hiding this comment.
Thanks @ardislu
Unfortunately, this will prevent scrolling long list of files. In the example below I get 44 files untracked. The list is not vertically scrollable any longer with your change. So I cannot look at all the files:
This is the closest parent container to the button so it's more accurate
|
Thank you @fcollonval for this feedback, I didn't check the case where there's a lot of files. I've moved the |
|
Kicking the CI |
fcollonval
changed the title
|
Congrats on your first merged pull request in this project! 🎉 |
* Set overflow in both directions to hidden Otherwise a vertical scrollbar will appear when child button is clicked. * Move overflow: hidden to button wrapper This is the closest parent container to the button so it's more accurate
Otherwise a vertical scrollbar will appear when a button within the file list is clicked.
Closes #1210