Style issues with SVG icons #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/binder @krassowski Could you please test this PR to check it fixes the style problems you found? |
|
|
|
It behaves much better. All the icon sizing issues are gone, and scrolling seems better, although it is still not perfect - if the list is long enough, a second scrollbar appear:
Edit: Nice binder bot! |
|
Thanks @krassowski Regarding the scroll bar, double scroll bars is per design needed. But the second should be on the all panel if needed. I created a new issue for it. So I can merge this and release a patch version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #793
Got the scrolling weird effect to disappear by switching to pure div elements rather than ul/li for changed files list.