Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent empty JSON body from causing None error in git config endpoint #959

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Prevent empty JSON body from causing None error in git config endpoint #959

merged 2 commits into from
Jun 24, 2021

Conversation

DarkmatterVale
Copy link
Contributor

Notes

Tests

  • pytest jupyterlab_git, verified all tests pass

@welcome
Copy link

welcome bot commented Jun 22, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch DarkmatterVale/jupyterlab-git/master

fcollonval
fcollonval requested changes Jun 23, 2021
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DarkmatterVale thanks for the fix. I would suggest a slightly more robust approach to prevent this to happen in the future. Let me know what you think.

jupyterlab_git/handlers.py Outdated Show resolved Hide resolved
jupyterlab_git/handlers.py Outdated Show resolved Hide resolved
@fcollonval fcollonval merged commit c5e09cb into jupyterlab:master Jun 24, 2021
@welcome
Copy link

welcome bot commented Jun 24, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval requested changes

@tleonhardt tleonhardt tleonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkmatterVale @tleonhardt @fcollonval