Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve commit amend selection #994

Merged
merged 5 commits into from
Aug 4, 2021
Merged

Improve commit amend selection #994

merged 5 commits into from
Aug 4, 2021

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Aug 3, 2021 •
edited
Loading

Fixes #981

image

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

Binder 👈 Launch a binder notebook on branch fcollonval/jupyterlab-git/fcollonval/issue981

@fcollonval
Copy link
Member Author

cc @krassowski @SinaKhalili what do you think?

@krassowski
Copy link
Member

krassowski commented Aug 3, 2021 •
edited
Loading

I would use consider using non-thin version of the caret. Should it be the down caret up up caret? Or maybe ⋮?

@fcollonval
Copy link
Member Author

I would consider using non-thin version of the caret. Should it be the down caret up up caret? Or maybe ⋮?

Indeed a ⋮icon will be more appropriate as the pop up will never be displayed below.

@fcollonval
Copy link
Member Author

The icon has been updated to ⋮

@fcollonval fcollonval merged commit 1c07f6f into jupyterlab:master Aug 4, 2021
@fcollonval fcollonval deleted the fcollonval/issue981 branch August 4, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UX for commit amend
2 participants
@fcollonval @krassowski