Remove IDragEvent deprecated tag
#561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afshin
added
bug
fcollonval
reviewed
Mar 20, 2023
| @@ -38,8 +38,6 @@ export type SupportedActions = | |||
| * events, a drop target must cancel the `'lm-dragenter'` event by | |||
| * calling the event's `preventDefault()` method. | |||
| * | |||
| * @deprecated This interface will be deprecated in @lumino/dragdrop@^2.0.0 in favor | |||
There was a problem hiding this comment.
Should we keep the comment even if there is no tag to properly highlight it?
There was a problem hiding this comment.
Yeah that's a good point. As long as it doesn't create a behavior in an IDE that looks out for the @deprecated tag, the information itself doesn't hurt.
afshin
changed the title
IDragEvent deprecated tag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a
@deprecatedwarning because it is actually a warning about future deprecation.Fixes #559.