Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dev dependencies #599

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Jun 22, 2023

Bump:

  • Typescript 4.9 -> 5.1
  • Yarn 3.4 -> 3.6.
  • Lerna 6.3 -> 7.1
  • Prettier 2.7 -> 3
  • typedoc 0.23 -> 0.24

@fcollonval fcollonval added the maintenance Dependencies, build, technical debt, etc. label Jun 22, 2023
@fcollonval fcollonval force-pushed the maintenance/upgrade-dev-deps branch from 748dc84 to 87be071 Compare June 23, 2023 08:14
@fcollonval
Copy link
Member Author

I think it is safe to bump TypeScript from 4.9 t 5.1. But as we had issue before while bumping TypeScript, I would appreciate thoughts from other devs.

cc @jupyterlab/jupyterlab-council

@echarles
Copy link
Member

I guess yarn and lerna deserve a bunch of attention also. My feedbacks

  • CI should ideally be green and stable (now failing on Tests/build)
  • I have tested on my local env with yarn, yarn build and yarn test and it works fine
  • Most important, JupyterLab should be aligned with those changes. Any PR for that?

@jtpio
Copy link
Member

jtpio commented Jun 26, 2023

I think it is safe to bump TypeScript from 4.9 t 5.1. But as we had issue before while bumping TypeScript, I would appreciate thoughts from other devs.

This PR may be relevant for the TypeScript 5.1 update: jupyterlab/jupyterlab#14638

@fcollonval
Copy link
Member Author

CI should ideally be green and stable (now failing on Tests/build)

👍 CI is greener (failing test are due to flakiness)

Most important, JupyterLab should be aligned with those changes. Any PR for that?

@echarles would you mind giving more details about your thinking here? I don't see the reasons for dev deps alignement between Lab and Lumino (it has almost never been true in the past).


FYI I computed the diff for the types of @lumino/widgets between main and this PR:

diff --color packages/widgets/types/index.d.ts packages/widgets/types.bak/index.d.ts
0a1,4
> /**
>  * @packageDocumentation
>  * @module widgets
>  */
Only in packages/widgets/types.bak: tsdoc-metadata.json

The only change is the documentation addition by this PR. So it seems we will avoid the trouble hit in the past.

@echarles
Copy link
Member

@echarles would you mind giving more details about your thinking here? I don't see the reasons for dev deps alignement between Lab and Lumino (it has almost never been true in the past).

I sometimes had to develop in both lumino and jupyterlab source base (one depending on the other).

That's fine if it is not the case, it will just make life a bit harder some days.

@fcollonval fcollonval merged commit 2c216e9 into jupyterlab:main Jul 17, 2023
16 of 17 checks passed
@fcollonval fcollonval deleted the maintenance/upgrade-dev-deps branch July 17, 2023 13:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants