Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #665

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Update README.md #665

merged 1 commit into from
Dec 13, 2023

Conversation

novrain
Copy link
Contributor

@novrain novrain commented Dec 13, 2023

Add an example which using lumino in Vue3.

@novrain
Update README.md
47ec1c5 
Add an example which using lumino in Vue3.
@welcome Welcome
Copy link

welcome bot commented Dec 13, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski krassowski added the documentation Improvements or additions to documentation label Dec 13, 2023
fcollonval
fcollonval approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing @novrain

@fcollonval fcollonval merged commit 7f4bd51 into jupyterlab:main Dec 13, 2023
17 of 19 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 13, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@novrain
Copy link
Contributor Author

novrain commented Dec 14, 2023 •
edited
Loading

Thanks for sharing @novrain

Thanks lumino, it's great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@novrain novrain

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@novrain @fcollonval @krassowski