Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in EtcdMemberReconciler #4435

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix error handling in EtcdMemberReconciler #4435

merged 1 commit into from
May 17, 2024

Conversation

jnummelin
Copy link
Member

The watch for CRD getting ready used wrong error when checking if it is retriable. This results in bogus logging and a "busyloop":

time="2024-05-16 10:05:45" level=info msg="Transient error while watching etcdmember CRD, last observed version is \"\", starting over after 0s ..." component=etcdMemberReconciler error="<nil>"
time="2024-05-16 10:05:45" level=info msg="Transient error while watching etcdmember CRD, last observed version is \"\", starting over after 0s ..." component=etcdMemberReconciler error="<nil>"
time="2024-05-16 10:05:45" level=info msg="Transient error while watching etcdmember CRD, last observed version is \"\", starting over after 0s ..." component=etcdMemberReconciler error="<nil>"
...

It actually hides the transient errors encountered.

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jnummelin jnummelin added bug Something isn't working area/controlplane component/etcd backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels May 16, 2024
@jnummelin jnummelin requested a review from a team as a code owner May 16, 2024 13:24
@jnummelin jnummelin requested review from ncopa and makhov May 16, 2024 13:24
twz123
twz123 previously approved these changes May 16, 2024
View reviewed changes
pkg/component/controller/etcd_member_reconciler.go Outdated Show resolved Hide resolved
pkg/component/controller/etcd_member_reconciler.go Outdated Show resolved Hide resolved
@jnummelin
Fix error handling in EtcdMemberReconciler
d67b442 
The watch for CRD getting ready used wrong error when checking if it is retriable. This results in bogus logging and a "busyloop":
```
time="2024-05-16 10:05:45" level=info msg="Transient error while watching etcdmember CRD, last observed version is \"\", starting over after 0s ..." component=etcdMemberReconciler error="<nil>"
time="2024-05-16 10:05:45" level=info msg="Transient error while watching etcdmember CRD, last observed version is \"\", starting over after 0s ..." component=etcdMemberReconciler error="<nil>"
time="2024-05-16 10:05:45" level=info msg="Transient error while watching etcdmember CRD, last observed version is \"\", starting over after 0s ..." component=etcdMemberReconciler error="<nil>"
...
```

It actually hides the transient errors encountered.

Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
@jnummelin jnummelin force-pushed the fix/etcd-member-error-handling branch from 64ea576 to d67b442 Compare May 17, 2024 07:42
@jnummelin
Copy link
Member Author

@twz123 Resolved the comments, good points. PTAL again

@twz123 twz123 merged commit 326a7f0 into k0sproject:main May 17, 2024
77 checks passed
@k0s-bot
Copy link

k0s-bot commented May 17, 2024

Successfully created backport PR for release-1.30:

@k0s-bot k0s-bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makhov makhov makhov approved these changes

@twz123 twz123 twz123 approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/controlplane backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch bug Something isn't working component/etcd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jnummelin @k0s-bot @makhov @twz123