Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use statically initialized runtime schemes #4537

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Use statically initialized runtime schemes #4537

merged 1 commit into from
Jun 5, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 4, 2024

Description

This fixes a potential panic during k0s startup when components are started at the same time that register new types for shared schemes.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added bug Something isn't working backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels Jun 4, 2024
@twz123 twz123 linked an issue Jun 4, 2024 that may be closed by this pull request
Panic: concurrent map read and map write #4532
Closed
@twz123 twz123 force-pushed the proper-scheme-initialization branch from dc162f2 to a3a2579 Compare June 4, 2024 09:52
@twz123 twz123 marked this pull request as ready for review June 4, 2024 12:11
@twz123 twz123 requested a review from a team as a code owner June 4, 2024 12:11
@twz123 twz123 requested review from ncopa and jnummelin June 4, 2024 12:11
@twz123
Copy link
Member Author

twz123 commented Jun 4, 2024

The DCO check is hanging... Will probably need force-push in order to retrigger this.

@twz123
Use statically initialized runtime schemes
7743df2 
This fixes a potential panic during k0s startup when components are
started at the same time that register new types for shared schemes.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 force-pushed the proper-scheme-initialization branch from a3a2579 to 7743df2 Compare June 5, 2024 11:15
@twz123 twz123 merged commit 4f2611f into k0sproject:main Jun 5, 2024
78 checks passed
@twz123 twz123 deleted the proper-scheme-initialization branch June 5, 2024 13:38
@k0s-bot
Copy link

k0s-bot commented Jun 5, 2024

Successfully created backport PR for release-1.30:

@k0s-bot k0s-bot mentioned this pull request Jun 5, 2024
Merged
@jnummelin jnummelin mentioned this pull request Jun 14, 2024
Closed
4 tasks
@twz123 twz123 mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic: concurrent map read and map write
3 participants
@twz123 @k0s-bot @jnummelin