[Backport release-1.29] [helm] don't start reconciler before leaderelection #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slices package in the standard library is sufficient for k0s's requirements nowadays. So let's use it. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Prior to this commit it was possible that some charts weren't reconciled due to lack of active leaders. See k0sproject#4637 for further details. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
|
@juanluisvaladas Do I get it correctly, this PR now has both #4714 AND #4039 in? |
|
🤦 Looking at the commits makes it obvious that it has both those PRs cherrypicked. |
jnummelin
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #4714. The cherry pick of #4714 works automatically after cherry-picking #4039. This one however had a small conflict in go.mod and conflict in the imports of
pkg/component/controller/extensions_controller.go. The changes were trivial so if it passes CI I trust it.The backport itself is trivial. @jnummelin I assign it to you because we discussed this yesterday.