Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove minReadySeconds from kube-router DaemonSet #4957

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Remove minReadySeconds from kube-router DaemonSet #4957

merged 1 commit into from
Sep 16, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Sep 11, 2024

Description

The minReadySeconds are a thing for StatefulSets. For DaemonSets there's no such field at all. Simply remove it as it has no effect, despite producing logs like 'unknown field "spec.template.spec.minReadySeconds"'.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Remove minReadySeconds from kube-router DaemonSet
c00fd0d 
The minReadySeconds are a thing for StatefulSets. For
DaemonSets there's no such field at all. Simply remove it as
it has no effect, despite producing logs like 'unknown field
"spec.template.spec.minReadySeconds"'.

Fixes: 65fcf39 ("Add readinessProbe/minReadySeconds to kube-router")
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added bug Something isn't working area/controlplane component/kube-router backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels Sep 11, 2024
@twz123 twz123 marked this pull request as ready for review September 11, 2024 11:40
@twz123 twz123 requested a review from a team as a code owner September 11, 2024 11:40
@twz123 twz123 merged commit a1dac3d into k0sproject:main Sep 16, 2024
88 checks passed
@twz123 twz123 deleted the kuberouter-no-minreadysecs branch September 16, 2024 08:08
@k0s-bot
Copy link

k0s-bot commented Sep 16, 2024

Successfully created backport PR for release-1.30:

@k0s-bot k0s-bot mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/controlplane backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch bug Something isn't working component/kube-router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @jnummelin