Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture errors when creating new users in inttests #5022

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Sep 22, 2024

Description

Remove error redirection. Instead, use separate buffers for stdout and stderr. This way, any errors during user creation will be properly reported.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Remove error redirection. Instead, use separate buffers for stdout
and stderr. This way, any errors during user creation will be properly
reported.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 marked this pull request as ready for review September 22, 2024 19:50
@twz123 twz123 requested a review from a team as a code owner September 22, 2024 19:50
@twz123 twz123 requested review from kke and makhov September 22, 2024 19:50
@twz123 twz123 merged commit 0028231 into k0sproject:main Sep 25, 2024
89 checks passed
@twz123 twz123 deleted the inttest-user-creation-errors branch September 25, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants