Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the autopilot client before applying the plan #5024

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Sep 23, 2024

Description

If it's done the other way round, it might happen that the k0s binary is being replaced by the autopilot update process, and cannot be executed.

This prevents errors like this:

Process exited with status 126: "sh: /usr/local/bin/k0s: Permission denied"

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

If it's done the other way round, it might happen that the k0s binary is
being replaced by the autopilot update process, and cannot be executed.

This prevents errors like this:

> Process exited with status 126: "sh: /usr/local/bin/k0s: Permission denied"

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added bug Something isn't working area/smoke-tests labels Sep 23, 2024
@twz123 twz123 marked this pull request as ready for review September 23, 2024 11:31
@twz123 twz123 requested a review from a team as a code owner September 23, 2024 11:31
Copy link
Member

@jnummelin jnummelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, I've been banging my head with this same thing on my grab backport fix attempts

@twz123 twz123 merged commit 1ead5bf into k0sproject:main Sep 23, 2024
89 checks passed
@twz123 twz123 deleted the ap-inttest-kubeconfig branch September 23, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/smoke-tests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants