Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kine to 0.13.2 #5069

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Bump kine to 0.13.2 #5069

merged 1 commit into from
Oct 3, 2024

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented Oct 2, 2024

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ncopa ncopa requested a review from a team as a code owner October 2, 2024 17:46
@ncopa ncopa added the backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch label Oct 2, 2024
twz123
twz123 reviewed Oct 2, 2024
View reviewed changes
pkg/component/controller/kine.go Outdated
@@ -122,7 +122,7 @@ func (k *Kine) Start(ctx context.Context) error {
fmt.Sprintf("--endpoint=%s", k.Config.DataSource),
// NB: kine doesn't parse URLs properly, so construct potentially
// invalid URLs that are understood by kine.
// https://github.com/k3s-io/kine/blob/v0.13.0/pkg/endpoint/endpoint.go#L271-L279
// https://github.com/k3s-io/kine/blob/v0.13.2/pkg/endpoint/endpoint.go#L271-L279
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That code block moved between 0.13.0 and 0.13.2. Not sure where it went. Need to check when back at a bigger screen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:
https://github.com/k3s-io/kine/blob/c1b2bd81f697c6b7aec85ea2562bcbcdfb981307/pkg/util/network.go#L5-L13

commit which changed it:
k3s-io/kine@133503d#diff-4dc3c0ec47d04feb9a369ad9a22481196e2eb42ca9e7442728e97070b8b0314fR134

@ncopa ncopa merged commit 46e605d into k0sproject:main Oct 3, 2024
15 checks passed
@ncopa ncopa deleted the kine-0.13.2 branch October 3, 2024 11:48
@k0s-bot
Copy link

k0s-bot commented Oct 3, 2024

Successfully created backport PR for release-1.31:

@k0s-bot k0s-bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twz123 twz123 twz123 left review comments

@juanluisvaladas juanluisvaladas juanluisvaladas approved these changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncopa @k0s-bot @twz123 @juanluisvaladas