Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add oras pull capabilities #5075

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add oras pull capabilities #5075

wants to merge 2 commits into from
+476 −0

Conversation

ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Oct 3, 2024 •
edited
Loading

Description

implement logic to download artifacts from a registry using oras. these are not yet in use but will soon be. this is part of the implementation for this adr.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ricardomaraschini ricardomaraschini force-pushed the adds-download-from-oras-function branch 2 times, most recently from dabdb5a to b6c3686 Compare October 3, 2024 18:46
@ricardomaraschini ricardomaraschini marked this pull request as ready for review October 3, 2024 18:55
@ricardomaraschini ricardomaraschini requested a review from a team as a code owner October 3, 2024 18:55
@ricardomaraschini
feat: add oras pull capabilities
b5e2955 
implement logic to download artifacts from a registry using oras. these
are not yet in use but will soon be.

Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
laverya
laverya reviewed Oct 4, 2024
View reviewed changes
internal/oras/oras.go Outdated Show resolved Hide resolved
@ricardomaraschini @laverya
Update internal/oras/oras.go
b0fb0e8 
Co-authored-by: Andrew Lavery <laverya@umich.edu>
Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laverya laverya laverya left review comments

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardomaraschini @laverya