Refactor driver selection to allow registering new drivers #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav
force-pushed
the
refactor-generic
branch
from
7de1ad5
to
8ef18f1
Compare
brandond
reviewed
Sep 25, 2024
brandond
reviewed
Sep 25, 2024
sambhav
force-pushed
the
refactor-generic
branch
from
8ef18f1
to
fc610d8
Compare
brandond
requested changes
Sep 25, 2024
brandond
requested changes
Sep 25, 2024
|
Looks like it's still not formatted properly: |
sambhav
force-pushed
the
refactor-generic
branch
from
ba88a2c
to
80e966a
Compare
|
Should work now, rebased and squashed all the fixes. |
|
Hmm
|
sambhav
force-pushed
the
refactor-generic
branch
6 times, most recently
from
83fc148
to
5016d49
Compare
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
sambhav
force-pushed
the
refactor-generic
branch
from
5016d49
to
5594b15
Compare
brandond
approved these changes
Sep 26, 2024
vitorsavian
approved these changes
Sep 26, 2024
|
@brandond ok to merge this? Would you also be open to cutting a release? |
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Oct 2, 2024
Support for 'sqlite' as the endpoint was removed in k3s-io/kine#320 and the constant removed in k3s-io/kine#325 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to k3s-io/k3s
that referenced
this pull request
Oct 3, 2024
Support for 'sqlite' as the endpoint was removed in k3s-io/kine#320 and the constant removed in k3s-io/kine#325 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the driver code to allow users to register their own drivers if they wish to.
It also consolidates the I/O that is expected from each driver constructor to a consistent interface.
Fixes #76 as well