This repository has been archived by the owner on Oct 6, 2021. It is now read-only.
Move pageTransitionSupport into Maji library #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalw
force-pushed
the
feature/move-page-transition-support-into-library
branch
6 times, most recently
from
46485f4
to
00aa9f9
Compare
pascalw
changed the title
leonderijke
approved these changes
Nov 30, 2017
|
Ah yes will do. I keep forgetting this hehe :-) |
ruisalgado
approved these changes
Dec 6, 2017
It's generic enough + allows us to apply bugfixes/changes easily.
pascalw
force-pushed
the
feature/move-page-transition-support-into-library
branch
from
00aa9f9
to
1ca4474
Compare
|
Changelog updated. |
pascalw
deleted the
feature/move-page-transition-support-into-library
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the page transition support into the library. This way it's not duplicated across project and allows us to apply bugfixes and improvements transparently.