This repository has been archived by the owner on Mar 29, 2020. It is now read-only.
:= fixes issue #14 and upgrades Scala and the dependencies #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Solves issue NoSuchMethodError in ZipkinReporter.convertSpan in Play2.8 app #14 :
The second parameterpassed to
Math.floorDiv()
(value1000
) needs to be forced toLong
. Otherwise, the Scala compiler doesn't generate the correct invocation in the bytecode generated.Upgrades to Scala
2.12.11
and upgrade the minor version of the depedencies.