add disables colorized output option #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujiwara
reviewed
Jul 19, 2024
cli.go
Outdated
| @@ -16,6 +16,7 @@ type CLIOptions struct { | |||
| AssumeRoleARN string `help:"the ARN of the role to assume" default:"" env:"ECSPRESSO_ASSUME_ROLE_ARN"` | |||
| Timeout *time.Duration `help:"timeout. Override in a configuration file." env:"ECSPRESSO_TIMEOUT"` | |||
| FilterCommand string `help:"filter command" env:"ECSPRESSO_FILTER_COMMAND"` | |||
| NoColor bool `help:"disables colorized output" default:"false"` | |||
There was a problem hiding this comment.
I think the negative flag that has a default false value is confusing a little.
alecthomas/kong has the negatable attribute to make --no-xxx flag from the positive flag --xxx automatically.
Suggested change
| NoColor bool `help:"disables colorized output" default:"false"` | |
| Color bool `help:"enable colorized output" env:"ECSPRESSO_COLOR" default:"true" negatable:""` |
There was a problem hiding this comment.
Fixed in aee93f2 .
Thanks for the suggestion！
cliv2.go
Outdated
Comment on lines
40
to
42
| if opts.NoColor { | ||
| color.NoColor = true | ||
| } |
There was a problem hiding this comment.
Suggested change
| if opts.NoColor { | |
| color.NoColor = true | |
| } | |
| color.NoColor = !opts.Color |
|
@ch1aki Thank you! I've commented. |
|
@ch1aki Thank you! merged. This will be released in v2.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to easily disable terminal formatting sequences when automatically commenting on a PR with the results of ecspresso diff, using tools like suzuki-shunsuke/github-comment."
colorized
no color