Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--features flag doesn't work with --all #39

Open
asomers opened this issue Jan 1, 2019 · 1 comment
Open

--features flag doesn't work with --all #39

asomers opened this issue Jan 1, 2019 · 1 comment

Comments

@asomers
Copy link

asomers commented Jan 1, 2019

I have a workspace with a virtual manifest and multiple crates. If I run cargo kcov --features foo directly in the subcrate's directory, then the tests build and run with foo enabled. However, if I run cargo kcov --all --features foo from the top directory, then the --features flag seems to be ignored. Shouldn't cargo-kcov pass that feature through to all subcrates? Or if that's not possible, then it should probably be an error to combine --features with --all.
@mbrobbel
Copy link

rust-lang/cargo#5015

asomers added a commit to bfffs/bfffs that referenced this issue Sep 20, 2019
@asomers
Workaround a bug in cargo-kcov
be7ac79 
cargo-kcov doesn't work with features and workspaces.
kennytm/cargo-kcov#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asomers @mbrobbel