Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent Characteristic Objects #32

Closed
9 tasks done
kevincar opened this issue May 8, 2021 · 0 comments · Fixed by #39
Closed
9 tasks done

Independent Characteristic Objects #32

kevincar opened this issue May 8, 2021 · 0 comments · Fixed by #39
Assignees
Labels
enhancement New feature or request

Comments

@kevincar
Copy link
Owner

kevincar commented May 8, 2021

Describe the solution you'd like
Characteristic objects should be able to be stand alone objects. This doesn't guarantee that the underlying OS-specific BLE characteristic has been initialized since some implementations are dependent on the system as a whole. Rather the class defines the basic properties and functions of the characteristic but do not guarantee full function until it is incorporated into a whole app etc.

  • constructor should take only values that describe the characteristic to be made; i.e., it should not be dependent on a service_uuid, but rather can be associated with a service later.
  • Logic for building the os object where initialization of such objects requires more than the characteristic should be moved else where
  • uuid should be a Union[str, UUID] type. Regardless of input type, all strings should be converted to UUID
  • Where appropriate service uuid should be added / modified
  • Add general and os-sepcific unit tests where appropriate
@kevincar kevincar added the enhancement New feature or request label May 8, 2021
@kevincar kevincar added this to the Standalone Classes milestone May 8, 2021
@kevincar kevincar self-assigned this May 8, 2021
kevincar added a commit that referenced this issue May 8, 2021
kevincar added a commit that referenced this issue May 14, 2021
@kevincar kevincar linked a pull request May 15, 2021 that will close this issue
@kevincar kevincar mentioned this issue May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant