Develop #109
Merged
Develop #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-checks-all-service-providers Only one service advertize for server
…nly-after-i-kill-the-server 87 write request get executed only after i kill the server
Adjusting interval is classified as Experimental in BlueZ and really work only: when BlueZ is compiled with such option (usually it is) and when "bluetoothd" daemon is started with -E, --experimental option (usually it's not) They are taken into account only with Kernel v5.11+ and BlueZ v5.65+. It's a known fact that BlueZ verions 5.63-5.64 have broken Dbus part for LEAdvertisingManager and do not work properly when the Experimental mode is enabled.
Decrease default Advertisement interval from 1200 to 100 ms
Currently neither application nor advertisement are unregistered on server stop. This leads to an re-export in case of a later start() which dbus-fast will acknoledge with an exception: ``` ValueError: An interface with this name is already exported on this bus at path "/": "org.bluez" ``` Instead of only exporting once and keeping track internally we instead unexport the interfaces on server shutdown. Signed-off-by: Mimoja <git@mimoja.de>
BlueZDBus: Unexport app and advertisement on stop()
The local name can be any utf-8 chars, but dbus requires a limited ASCII character set. dbus-next will reject paths until they're [A-Za-z0-9_].#
Ensure dbus object path is only valid chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.